-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2e Reveal Secret Recovery Phrase Quiz answer confirmation #10273
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
revert android emulator to default
revert to original after ignoring all logs for debugging
remove unused
remove unneeded changes since SRP reveal is out of scope for quiz completion spec at this time.
|
|
@plasmacorral you can look at swaps use of fixtures and see it that works for your tests.
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this 👏, I have left some feedback
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js
Outdated
Show resolved
Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js
Outdated
Show resolved
Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js
Outdated
Show resolved
Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js
Outdated
Show resolved
Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js
Outdated
Show resolved
Hide resolved
e2e/selectors/Settings/SecurityAndPrivacy/RevealSeedView.selectors.js
Outdated
Show resolved
Hide resolved
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Description
This pull request introduces a new test that navigates through the Secret Recovery Phrase reveal quiz, up to the password entry prompt. It verifies that the flow can be successfully completed when incorrect answers are provided and then resubmitted with the correct answer chosen.
Related issues
Fixes: 492
Manual testing steps
Not applicable
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist